Skip to content

impr: use preload for vendor.css and fonts (@fehmer) #6234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Miodec merged 8 commits into from
Feb 19, 2025
Merged

impr: use preload for vendor.css and fonts (@fehmer) #6234

Miodec merged 8 commits into from
Feb 19, 2025
+88 −1

Conversation

@fehmer
Copy link
Member

@fehmer fehmer commented Feb 4, 2025 •
edited
Loading

The preload on the vendor.scss is not working in production as intended.

  • Using the unplugin-inject-preload to inject preload header for the vendor.css and the fontawesome fonts
  • Add preload for the default fonts RobotoMono and LexendDeca
  • Load the service worker registerSW.js with defer to not block rendering

Chrome performance tools

old new
score 67 72
first paint 2.4s 2.1s
largest paint 3.3s 2.9s
LCP 1.18 (registerSW, index.css, serika_dark.css) 1.09 (index.css, serika_dark.css)
layout shift 3 due to font requests none

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Feb 4, 2025
@fehmer fehmer force-pushed the feature/fix-css-preload branch from c134973 to f2ad6d4 Compare February 4, 2025 12:17
fehmer
fehmer commented Feb 4, 2025
View reviewed changes
@fehmer fehmer marked this pull request as ready for review February 13, 2025 19:03
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Feb 13, 2025
@fehmer fehmer added the format Ask the bot to fix formatting on this pr label Feb 17, 2025
@github-actions github-actions bot removed the format Ask the bot to fix formatting on this pr label Feb 17, 2025
@Miodec Miodec merged commit cad977e into master Feb 19, 2025
11 checks passed
@Miodec
Copy link
Member

Miodec commented Feb 19, 2025

Thanks

@Miodec Miodec deleted the feature/fix-css-preload branch February 19, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fehmer @Miodec @monkeytypegeorge